Data html attributes

[robertKozik]

This PR extends usage of the shouldKeepWhitespace flag which was created for Live Markdown Preview.

• changes the name of the flag to shouldKeepRawInput to indicate extended usability of the flag
• based on this flag new replacement method can be called if implemented for every rule.
• new replacement method should return similar HTML structure as normal replacement but enrich the tag with unmodified values of input which is necessary for Live Markdown Preview
• unmodified values are exposed by rawInputReplacement functions as new HTML attributes:
  • data-code-raw - contains escaped version of code block, new lines/whitespaces included
  • data-raw-href - contains unmodified version of the link/email
  • data-link-variant - contains information whether the link was typed as labeled link or as auto link
  • link labels are passed unmodified

Screen.Recording.2023-12-20.at.21.12.04.mov

Fixed Issues

$ Expensify/App#33026
$ Expensify/App#31181

Tests

1. What unit/integration tests cover your change? What autoQA tests cover your change?
   New unit tests were implemented in order to test the changes. To test it by yourself you will need example app.

2. What tests did you perform that validates your changed worked?

QA

1. What does QA need to do to validate your changes?
   Same as tests
2. What areas to they need to test for regressions?
   This PR shouldn't introduce any changes within parsing the messages while sending. We can ensure it by checking how links/mails are parsed while being send within the expensify app

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[robertKozik]

I have read the CLA Document and I hereby sign the CLA

[hayata-suenaga]

A C+ will review this RP soon. I pinged them

[situchan]

New unit tests were implemented in order to test the changes. To test it by yourself you will need example app

@robertKozik I don't have access to this repo

https://github.com/tomekzaw/react-native-markdown-text-input/tree/remove-newline-char-codeblock

[robertKozik]

Hi @situchan, unfortunately, afaik I cannot grant you access to the repo. I believe code review and unit tests should be sufficient in this particular case, along with checking for any regression in the Expensify app. These changes shouldn't impact the normal messaging flow inside new-dot.
cc. @tomekzaw

[robertKozik]

Hey @situchan how is review going?

[situchan]

Code LGTM. I will complete test by tomorrow

[robertKozik]

How is the progress @situchan ?

[situchan]

• code review ✅
• unit tests ✅
• checking for any regression in the Expensify app. These changes shouldn't impact the normal messaging flow inside new-dot ✅
• test live markdown in new RN app ❌

[robertKozik]

@hayata-suenaga Hi! Can we proceed further with merge after @situchan review?

[hayata-suenaga]

code looks good to me, too

[hayata-suenaga]

@situchan just to double confirm, are we good to merge this?

[situchan]

@situchan just to double confirm, are we good to merge this?

yes. This repo doesn't require big checklist like app repo