Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply Italic marckdown for multiline-quote message #618

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Do not apply Italic marckdown for multiline-quote message #618

merged 2 commits into from
Dec 19, 2023

Conversation

byte1012
Copy link
Contributor

Fixed Issues

$ Expensify/App#26941
Proposal: Expensify/App#26941 (comment)

Tests

  1. Go to any chat.
  2. Type the following test strings and observe that it's parsed as expected
_test
> test_

*test
> test*

~test
> test~

QA

Same as tests step

Offline tests

Same as tests step

Screenshots/Videos

Web

image

Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@byte1012 byte1012 requested a review from a team as a code owner December 13, 2023 12:16
@melvin-bot melvin-bot bot requested review from johnmlee101 and removed request for a team December 13, 2023 12:16
@byte1012 byte1012 mentioned this pull request Dec 13, 2023
Closed
6 tasks
@s77rt
Copy link
Contributor

s77rt commented Dec 13, 2023

Screenshots desktop mweb-chrome mweb-safari web

@johnmlee101 johnmlee101 merged commit c6bb3cf into Expensify:main Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s77rt s77rt s77rt approved these changes

@johnmlee101 johnmlee101 johnmlee101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byte1012 @s77rt @johnmlee101 @r3770