-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mention user rule #600
Conversation
@ArekChr The PR is ready for review. For |
lib/ExpensiMark.d.ts
Outdated
@@ -57,13 +66,14 @@ export default class ExpensiMark { | |||
* | |||
* @param htmlString | |||
*/ | |||
htmlToMarkdown(htmlString: string): string; | |||
htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be treated as metadata, allowing us to pass various data through the second parameter.
E.g.
const metadata = { personalDetails }
htmlToMarkdown(html, metadata)
const metadata = { reportDetails }
htmlToMarkdown(html, metadata)
same in htmlToText.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the second parameter be optional?
htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string; | |
htmlToMarkdown(htmlString: string, personalDetails?: PersonalDetails): string; |
@ArekChr Thanks for your suggestion, I've updated |
Looks like we can close this |
Fixed Issues
$ Expensify/App#29978
Tests
QA
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2023-11-10.at.15.50.29.mov
iOS: mWeb Safari
Screen.Recording.2023-11-10.at.15.34.11.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-10.at.11.56.25.mov
MacOS: Desktop
Screen.Recording.2023-11-10.at.15.42.12.mov