feat(connext): reconcile deposit when channel balance changes #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
raladev
previously approved these changes
Dec 7, 2020
sangaman
previously approved these changes
Dec 8, 2020
ghost
force-pushed
the
feat/refactor-deposit
branch
from
44ad218 to
124bb22
Compare
ghost
force-pushed
the
feat/refactor-deposit
branch
from
124bb22 to
a68ab7d
Compare
|
@sangaman comments added - going to merge this. If the comments are not clear, I'll add more in a follow-up PR. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic around
/depositcalls. Previously, we were creating new commitment transaction every 5 seconds. With this PR we'll only create new state updates when the channel balance of ETH changes.Related issue: #2019