Run benchmarks on raw VM #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
May 26, 2020 14:31
sz-piotr
approved these changes
May 29, 2020
src/SimpleChain.ts
Outdated
|
|
||
| async sendTransaction (signedTransaction: HexData): Promise<Hash> { | ||
| const hash = await this.vm.addPendingTransaction(signedTransaction) | ||
| if (this.options.autoMining) { |
There was a problem hiding this comment.
A lot of things like this could be stripped, since you don't even have mine block in the provider.
Of course doing this is probably not worth the effort.
src/vm/getReceiptsAndResponses.ts
Outdated
| // eslint-disable-next-line | ||
| import { RunTxResult } from '@nomiclabs/ethereumjs-vm/dist/runTx' | ||
|
|
||
| export function getReceiptsAndResponses (block: Block, transactions: Transaction[], results: RunTxResult[]) { |
There was a problem hiding this comment.
We can probably get rid of this, unless we send transactions from ethers directly
There was a problem hiding this comment.
Not calling this function might have a performance impact, because it does a lot of buffer stringifying.
There was a problem hiding this comment.
Good point, I don't send any transactions from ethers, so I think it's safe to remove it.
added 5 commits
May 29, 2020 12:34
* remove autoMining option
added 14 commits
May 29, 2020 18:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not fully finished yet. The code sufficient to run all of the transactions and calls used in benchmarks against raw VM can be found in
srcandtestdirectories. The existing benchmarks are yet to be adjusted to make use of that code.In order to install dependencies:
in separate terminal window:
btw don't try running benchmarks because they don't work at the moment (
start,start:dirtyandbenchmarkscripts)