Merge pull request #609 from EspressoSystems/abdul/revert-tx

Rollback transaction if failed to store fetched resource

src/data_source/fetching/block.rs

@@ -277,6 +277,9 @@ where
         {
             let mut storage = self.fetcher.storage.write().await;
             if let Err(err) = store_block(&mut *storage, block).await {
+                // Rollback the transaction if insert fails
+                // This prevents subsequent queries from failing, as they would be part of the same transaction block.
+                storage.revert().await;
                 // It is unfortunate if this fails, but we can still proceed by returning
                 // the block that we fetched, keeping it in memory. Simply log the error and
                 // move on.

src/data_source/fetching/leaf.rs

@@ -216,6 +216,9 @@ where
                 tracing::info!("fetched leaf {height}");
                 let mut storage = fetcher.storage.write().await;
                 if let Err(err) = store_leaf(&mut *storage, leaf).await {
+                    // Rollback the transaction if insert fails
+                    // This prevents subsequent queries from failing, as they would be part of the same transaction block.
+                    storage.revert().await;
                     // It is unfortunate if this fails, but we can still proceed by
                     // returning the leaf that we fetched, keeping it in memory.
                     // Simply log the error and move on.

src/data_source/fetching/vid.rs

@@ -203,6 +203,9 @@ where
         {
             let mut storage = self.fetcher.storage.write().await;
             if let Err(err) = store_vid_common(&mut *storage, common).await {
+                // Rollback the transaction if insert fails
+                // This prevents subsequent queries from failing, as they would be part of the same transaction block.
+                storage.revert().await;
                 // It is unfortunate if this fails, but we can still proceed by returning
                 // the block that we fetched, keeping it in memory. Simply log the error and
                 // move on.