Use ETAG when poller is polling (#39)

Eppo-exp · Sep 3, 2024 · 17820d6 · 17820d6
1 parent ba99154
commit 17820d6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/Config/ConfigurationLoader.php b/src/Config/ConfigurationLoader.php
@@ -67,8 +67,7 @@ public function reloadConfigurationIfExpired(): void
     {
         $flagCacheAge = $this->getCacheAgeSeconds();
         if ($flagCacheAge === -1 || $flagCacheAge >= $this->cacheAgeLimit) {
-            $flagETag = $this->configurationStore->getMetadata(self::KEY_FLAG_ETAG);
-            $this->fetchAndStoreConfigurations($flagETag);
+            $this->reloadConfiguration();
         }
     }
 
@@ -179,4 +178,16 @@ private function fetchBanditsAsRequired(IBanditReferenceIndexer $indexer): void
             $this->fetchAndStoreBandits();
         }
     }
+
+    /**
+     * @return void
+     * @throws HttpRequestException
+     * @throws InvalidApiKeyException
+     * @throws InvalidConfigurationException
+     */
+    public function reloadConfiguration(): void
+    {
+        $flagETag = $this->configurationStore->getMetadata(self::KEY_FLAG_ETAG);
+        $this->fetchAndStoreConfigurations($flagETag);
+    }
 }
diff --git a/src/EppoClient.php b/src/EppoClient.php
@@ -119,7 +119,7 @@ public static function init(
             self::POLL_INTERVAL_MILLIS,
             self::JITTER_MILLIS,
             function () use ($configLoader) {
-                $configLoader->fetchAndStoreConfigurations();
+                $configLoader->reloadConfiguration();
             }
         );