Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jest to 29.7.0 to resolve vulnerability in semver #40

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

leoromanovsky
Copy link
Member

@leoromanovsky leoromanovsky commented Oct 19, 2023

Fixes: #issue

Motivation and Context

We need to upgrade semver to:

  • >= 7.5.2
  • >= 6.3.1

This is blocked by our current jest version

Screenshot 2023-10-19 at 12 10 57 AM

Description

after updating we see that:

  • the 6 branch is all on 6.3.1
  • 7 branch is on 7.5.4
➜  js-client-sdk git:(lr/upgrade/jest) ✗ yarn why semver
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "semver"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "semver@7.5.4"
info Has been hoisted to "semver"
info Reasons this module exists
   - Hoisted from "ts-jest#semver"
   - Hoisted from "ts-loader#semver"
   - Hoisted from "@typescript-eslint#eslint-plugin#semver"
   - Hoisted from "@microsoft#api-extractor#semver"
   - Hoisted from "@typescript-eslint#parser#@typescript-eslint#typescript-estree#semver"
   - Hoisted from "@microsoft#api-documenter#@rushstack#node-core-library#semver"
   - Hoisted from "jest#@jest#core#jest-snapshot#semver"
   - Hoisted from "jest#@jest#core#@jest#reporters#istanbul-lib-instrument#semver"
info Disk size without dependencies: "276KB"
info Disk size with unique dependencies: "300KB"
info Disk size with transitive dependencies: "332KB"
info Number of shared dependencies: 1
=> Found "@babel/core#semver@6.3.1"
info This module exists because "jest#@jest#core#@jest#transform#@babel#core" depends on it.
info Disk size without dependencies: "88KB"
info Disk size with unique dependencies: "88KB"
info Disk size with transitive dependencies: "88KB"
info Number of shared dependencies: 0
=> Found "make-dir#semver@6.3.1"
info This module exists because "jest#@jest#core#@jest#reporters#istanbul-lib-report#make-dir" depends on it.
info Disk size without dependencies: "88KB"
info Disk size with unique dependencies: "88KB"
info Disk size with transitive dependencies: "88KB"
info Number of shared dependencies: 0
=> Found "@babel/helper-compilation-targets#semver@6.3.1"
info This module exists because "jest#@jest#core#@jest#transform#@babel#core#@babel#helper-compilation-targets" depends on it.
info Disk size without dependencies: "88KB"
info Disk size with unique dependencies: "88KB"
info Disk size with transitive dependencies: "88KB"
info Number of shared dependencies: 0
=> Found "babel-plugin-istanbul#semver@6.3.1"
info Reasons this module exists
   - "jest#@jest#core#@jest#transform#babel-plugin-istanbul#istanbul-lib-instrument" depends on it
   - Hoisted from "jest#@jest#core#@jest#transform#babel-plugin-istanbul#istanbul-lib-instrument#semver"
info Disk size without dependencies: "88KB"
info Disk size with unique dependencies: "88KB"
info Disk size with transitive dependencies: "88KB"
info Number of shared dependencies: 0
✨  Done in 0.17s.

How has this been tested?

Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@aarsilv aarsilv assigned leoromanovsky and unassigned aarsilv Oct 20, 2023
@leoromanovsky leoromanovsky merged commit 2b95c27 into main Oct 23, 2023
2 checks passed
@leoromanovsky leoromanovsky deleted the lr/upgrade/jest branch October 23, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants