fix: missing bandit store for precomputedInit #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
commented
Jan 16, 2025
| @@ -650,6 +651,7 @@ export async function precomputedInit( | |||
| precomputedFlagStore: memoryOnlyPrecomputedFlagsStore, | |||
| requestParameters, | |||
| subject, | |||
| precomputedBanditStore: memoryOnlyPrecomputedBanditsStore, | |||
There was a problem hiding this comment.
We already provide this in offlinePrecomputedInit, but it was missing in precomputedInit where we need to provide an empty store to fill when fetching from the precomputed endpoints
Lines 741 to 745 in 90f6515
leoromanovsky
approved these changes
Jan 16, 2025
sameerank
deleted the
sameeran/missing-bandit-store-for-precomputed-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Description
How has this been tested?