fix: Multiple "concurrent" calls to init
causing multiple fetches.
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes FF-3804
Motivation and Context
Eppo saw a dramatic increase in requests to the API and it was determined through investigation that multiple calls to
init
were being made before previous calls finished. Our code did not handle that case and would run the initialization workload (including fetching) for eachinit
call until one of them resolved. This is bad because it causes additional network and CPU load for the client and increases the cost of delivery for Eppo.Description
init
renamed toexclusiveInit
and new method namedinit
to preserve API).init
and delegate if one exists.How has this been tested?