Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide event ingestion under a feature flag #164

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rasendubi
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 0701619

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
eppo_core Patch
rust-sdk Patch
python-sdk Patch
ruby-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@leoromanovsky leoromanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing how to do this.

@@ -36,7 +38,7 @@ serde-bool = "0.1.3"
serde_json = "1.0.116"
serde_with = { version = "3.11.0", default-features = false, features = ["base64", "hex", "macros"] }
thiserror = "2.0.3"
tokio = { version = "1.34.0", features = ["macros", "sync", "rt", "time"] }
tokio = { version = "1.34.0", default-features = false, features = ["macros", "sync", "rt", "time"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@rasendubi rasendubi merged commit aa0ca89 into main Jan 17, 2025
31 checks passed
@rasendubi rasendubi deleted the chore-hide-event-ingestion branch January 17, 2025 19:04
felipecsl added a commit that referenced this pull request Jan 17, 2025
* chore(event_ingestion): Try to adapt to new design

* add `sync` flag for `tokio` dependency (#160)

* add sync feature to tokio crate

* add changeset

* chore: bump versions before release (#161)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: fix typo in publish.yml update_ruby_lockfile step (#162)

* chore(ruby): update lockfile (#163)

* chore: hide event ingestion under a feature flag (#164)

* chore: bump versions before release (#165)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(ruby): update lockfile (#166)

* enable feature, use tokio timer advance

* more code review comments

* fix failing tests

* DRY up

---------

Co-authored-by: Leo Romanovsky <leoromanovsky@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Oleksii Shmalko <oleksii@geteppo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants