Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video): fetch youtube thumbnail for media_type=video #80

Open
wants to merge 4 commits into
base: gnome-40-42
Choose a base branch
from

Conversation

pinbraerts
Copy link

@pinbraerts pinbraerts commented Jan 5, 2025

POC #79

@pinbraerts pinbraerts changed the title feat(video): fetch youtube thumbnail for media_type=video #79 feat(video): fetch youtube thumbnail for media_type=video Jan 5, 2025
@pinbraerts
Copy link
Author

The highest quality (720p) is pretty low for a 2k screen

desktop

But for the main use case it is ok

tinted

It is also possible to download some part of the video and use it as a thumbnail

@Elinvention
Copy link
Owner

Thanks, this looks good! Often images from APOD are not high resolution either, so a 720p image should be fine too. It's definitely better than nothing...

@pinbraerts
Copy link
Author

So what should I do next?

Should I add a toggle in the settings for this functionality?

I am sitting at gnome 42, so I was planning to rebase onto master and submit another PR once the job is done

@pinbraerts
Copy link
Author

I suppose I should also consider the quality setting when replacing the URL

@Elinvention
Copy link
Owner

Well, I don't think the toggle in the settings is necessary, there are already quite a few switches. However there may be some privacy implications if we download from YouTube, so maybe it is necessary after all?

Yes, you can rebase for master (actually it's main) in a second PR.

Yes, the quality setting should be considered, but if the best quality is 720p, I'd say don't bother (720p is not exactly hi-res, is it?).

@pinbraerts pinbraerts force-pushed the youtube-thumbnail-33 branch from 3a51fdb to 7a2d1d3 Compare January 8, 2025 12:33
@pinbraerts
Copy link
Author

Added a setting and considered hq/lowres option

image

@pinbraerts
Copy link
Author

Also, there would be great to have some functional testing. Now I can't really test this PR. I've tried to set local time or pin the wallpaper. Seems like it would be fairly easy to mock apod api, gsettings and local time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants