Wandb step handling bugfix and feature #2580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
resume_from
argument whose value may contain=
, which under the current implementation gets oversplit resulting in an error.step
duringwandb.run.log
instead, defaulting to None, but if set through the samewandb_args
list allowing the editing of reports (to not have to add more logic around that, I think the behavior of having the report be based on the latest run is quite reasonable anyway) and passing the split-off value that way.Please let me know what you think about these changes, if edits are needed, or if the process works somewhat differently here :)