Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wandb step handling bugfix and feature #2580

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

sjmielke
Copy link
Contributor

This PR contains:

  1. a bugfix to the parsing of args that allows for the passing of the resume_from argument whose value may contain =, which under the current implementation gets oversplit resulting in an error.
  2. For projects without rewinding, where the above is not an option, allow for the explicit passing of the step during wandb.run.log instead, defaulting to None, but if set through the same wandb_args list allowing the editing of reports (to not have to add more logic around that, I think the behavior of having the report be based on the latest run is quite reasonable anyway) and passing the split-off value that way.

Please let me know what you think about these changes, if edits are needed, or if the process works somewhat differently here :)

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@baberabb
Copy link
Contributor

Thanks for this! LGTM, assuming you have tested it.

@sjmielke
Copy link
Contributor Author

Both changes tested as I was developing them, working as expected.

@baberabb baberabb merged commit b86aa21 into EleutherAI:main Dec 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants