feat: MultiSelect component #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenjwatkins
commented
Jan 14, 2025
| @@ -59,6 +59,7 @@ | |||
| "babel-loader": "^9.2.1", | |||
| "eslint": "^8.57.1", | |||
| "glob": "^8.1.0", | |||
| "jsdom": "^26.0.0", | |||
There was a problem hiding this comment.
had to move jsdom to the root since it's a sibling dependency of vitest which is also at the root. otherwise it may not be able to find it as it imports it internally.
also had to override nwsapi because in later versions it breaks query selecting for React useId() generations due to IDs returning double colons: :r0:
| { key: 16, label: "Raspberry" }, | ||
| { key: 17, label: "Strawberry" }, | ||
| { key: 18, label: "Tangerine" }, | ||
| { key: 19, label: "Ugli Fruit" }, |
There was a problem hiding this comment.
TIL what an Ugli Fruit is 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Changes
<MultiSelect />component✅ Checklist
Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:
Strikethroughany items that are not applicable to this pull request.