Skip to content

Commit

Permalink
fix: overflow for NexusLayoutMultipageContent (#1459)
Browse files Browse the repository at this point in the history
## 📝 Changes

before:

![Screenshot 2024-11-07 at 2 16
28 PM](https://github.com/user-attachments/assets/b9e0e751-6722-478e-975d-69f51e278921)

after:

![Screenshot 2024-11-07 at 2 17
08 PM](https://github.com/user-attachments/assets/16840959-c486-41a2-aae8-3be58ed772ef)



## ✅ Checklist

Easy UI has certain UX standards that must be met. In general,
non-trivial changes should meet the following criteria:

- [x] Visuals match Design Specs in Figma
- [x] Stories accompany any component changes
- [x] Code is in accordance with our style guide
- [ ] ~Design tokens are utilized~
- [ ] ~Unit tests accompany any component changes~
- [ ] ~TSDoc is written for any API surface area~
- [ ] ~Specs are up-to-date~
- [x] Console is free from warnings
- [x] No accessibility violations are reported
- [x] Cross-browser check is performed (Chrome, Safari, Firefox)
- [x] Changeset is added

~Strikethrough~ any items that are not applicable to this pull request.
  • Loading branch information
OskiTheCoder authored Nov 8, 2024
1 parent 8da6b85 commit 15309ec
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/short-hats-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@easypost/easy-ui": minor
---

fix: overflow for NexusLayoutMultipageContent component
10 changes: 9 additions & 1 deletion easy-ui-react/src/NexusLayout/NexusLayout.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { action } from "@storybook/addon-actions";
import { Meta, StoryObj } from "@storybook/react";
import React from "react";
import { Button } from "../Button";
import { Text } from "../Text";
import { HorizontalStack } from "../HorizontalStack";
import { Menu } from "../Menu";
import { NexusLayout } from "./NexusLayout";
Expand Down Expand Up @@ -174,7 +175,14 @@ export const MultipageContent: Story = {
</Button>
</HorizontalStack>
</NexusLayout.MultipageHeader>
<div style={{ height: 400 }}></div>
<div style={{ height: 400 }}>
<Text variant="body2">
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Cumque
obcaecati iusto neque architecto, quae dolore illo. Saepe ipsum
voluptates reprehenderit repellendus deleniti, molestias
placeat, consectetur et nihil quisquam, numquam pariatur!
</Text>
</div>
</NexusLayout.MultipageContent>
</NexusLayout.MultipageContainer>
</NexusLayout.Content>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
}

.content {
flex: 1 0 auto;
flex: 1;
padding: design-token("space.3") design-token("space.4");
}

0 comments on commit 15309ec

Please sign in to comment.