This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KGL-Math #19
base: master
Are you sure you want to change the base?
KGL-Math #19
Changes from 9 commits
1d6115d
2de935c
96b56b1
cb1bd79
8349a53
8fb028d
effc8c5
a72d815
2de0b1f
a3db960
013c278
f7b4dfa
cfb0220
5a8e180
2d0c6c2
8d02a27
edee669
5460339
5eb436b
10b5839
0ebe22b
048c9ba
0203337
e198e77
53eb5e0
647bb76
e3216cd
424dced
5bc6f8f
86c08aa
e82d4ce
25dd098
6e053e6
e449687
9fabc65
5e745f4
a56947c
469a7ec
59714eb
83c4a05
5d50ef2
bfb826a
327038e
9248275
4f0eec7
70d6f20
9e5ccaa
6a065bc
f4011a0
054f83b
6de46f8
980ddee
08afe2c
e059fc6
343205e
ff6976b
096d75e
b18f7eb
e7437cb
51d119a
162587f
a52cbf1
1dc7d75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
sqrt(lengthSquared)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was intending to save a function call (of the
lengthSquared
getter). Should I not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I trust the JVM to inline it but I'm not sure about LLVM. We can leave it until we start bench-marking.