Update fastcs version #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
reviewed
Dec 19, 2024
| @@ -140,7 +140,7 @@ async def update( | |||
| try: | |||
| if self.cache is not None: | |||
| response = await self.cache.get_response( | |||
| self.update_period, | |||
| self.update_period if self.update_period else 0.0, | |||
There was a problem hiding this comment.
An update period of None means this won't be added as a scan task at all! https://github.com/DiamondLightSource/FastCS/blob/main/src/fastcs/backend.py#L130
| ref_schema = YAML(typ="safe").load(data / "schema.json") | ||
| options_model = _extract_options_model(ThorlabsMFF) | ||
| target_schema = options_model.model_json_schema() | ||
| assert ref_schema == target_schema |
There was a problem hiding this comment.
This looks good. You are probably going to want a convenient way to regenerate the checked in schema, like a vscode task, or a script. pvi does the latter https://github.com/epics-containers/pvi/blob/main/tests/regenerate_test_output.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GDYendell Thoughts? (Especially w.r.t testing)
I would like to create a helper function from
test_schemathat could be reused by other devices and possibly placed in afastcs.testingnamespace. The only problem is I dont know how to do this with pytest. If I create a helper that does the assert, I seem to lose the dictionary diff capability