Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-91: Load sample image if specified in URL #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jan 8, 2025

JIRA ticket: LIMS-91
JIRA ticket: LIMS-523

Summary:

If you go to a URL like /containers/cid/317254/iid/152920/sid/6049306, although the correct container (317254) and inspection (152920) are loaded, the sample (6049306) is not.
Also, caching the sample images is unnecessary with modern internet speeds.

Changes:

  • Remove the preCache function and related variables
  • Convert the sample id to a string before comparing to samples in the model

To test:

  • Go to a proposal with plates (eg nt37104), then go to a container (eg /containers/cid/317254)
  • Check images are not being cached but are still loaded when you click on a well on the plate
  • Add an inspection id to the end of the URL, eg /iid/152920. Check the Inspections dropdown is showing the correct inspection (in this case, from 11/11/2024).
  • Add a sample id to the end of that URL, eg /sid/6049306. Check the correct well from the plate is shown, in this case well 35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants