Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1287: Improve workflow for responsive scheduling #889

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jan 7, 2025

JIRA ticket: LIMS-1287

Summary:

Users often fill out the scheduling question incorrectly when making a shipment, or not at all. This PR is to try and make it clearer for them and us.

Changes:

  • Change the Scheduling question to a compulsory radio button, storing the value in the db (rather than just Yes/No)
  • Only show the session dropdown if they say they have a scheduled session and a session exists
  • Split UDC and Imager into separate answers
  • If they ask for a session, ask if they require a long wavelength beamline (ie I23), and in that case dont ask further scheduling questions
  • Add a 'Something else' answer with the comments field then compulsory
  • Display the full scheduling and long wavelength answers on the View Shipment page
  • Make the various checkboxes all into Yes/No dropdowns for consistency

To test:

  • Go to a proposal with future sessions already scheduled, eg cm40607, then go to /shipments/add
  • Check if you choose a safety level of yellow or red, the only option is "I have a session already scheduled"
  • Choose "I have a session already scheduled", check that a dropdown appears with future sessions in, which is compulsory
  • Check Shipment Name and Lab Contact fields are compulsory
  • Create the shipment, check the fields have populated correctly, particularly the First Experiment, and also Hard Drive Enclosed and Tools Enclosed
  • Make another shipment, this time choose "I am sending pucks for Unattended Data Collection". Create the shipment, check this value is shown on the View Shipment page
  • Repeat but with "I am sending plates for in situ imaging"
  • Repeat with "Something else", check the Comments field is now compulsory
  • Make a shipment with "I would like a session to be scheduled", check some extra questions appear. Check if you say "Yes" to the long wavelength question, the other scheduling questions disappear. Change back to "No", fill in the other questions, check those answers are shown on the View Shipment page.
  • Check you can change the Scheduling answer on the View Shipment page, and the other questions appear if you choose "I would like a session to be scheduled" and disappear if you choose anything else
  • Go to a proposal with no future sessions scheduled, eg mx23694. Go to /shipments/add, check you cannot select "I have a session already scheduled"
  • Go to an in or sw proposal. Go to /shipments/add, choose "I would like a session to be scheduled", check there is now a question about Mail-in/remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant