Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1549: Disallow dispatch requests on dewars that are 'processing' #884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1549

Summary:

If a user requests a dewar dispatch while a dewar is 'processing' (in use on a beamline), the status of 'dispatch-requested' is lost when the pucks are unloaded.

(I can't work out why exactly, each unloaded container triggers this SP, which seems to not change dewarStatus if the container was already 'processing')

Changes:

  • Hide the 'Dispatch' and 'Transfer' buttons if the dewar status is processing. Users can 'deactivate' the dewar to get these buttons back.
  • Move the show/hide of buttons depending on location from HTML to JS
  • Move the show/hide of the link to the shipping service from HTML to JS
  • Move the show/hide of the 'Deactivate' button from CSS to JS

To test:

  • Go to the cm37235 proposal, and find a shipment with pucks that are assigned on the beamline (eg /shipments/sid/62271 at time of writing). The dewar should be highlighted green on the shipment page.
  • Check the buttons displayed next to the dewar are 'Deactivate', 'Print Report' and 'Add Container' (ie not Dispatch or Transfer)
  • Click 'Deactivate', check the 'Deactivate' button disappears and the 'Dispatch' and 'Transfer' buttons appear. Check they remain so after a refresh.
  • Go to a shipment that has been returned via the shipping service, and therefore has a location of 'stores-out', eg /shipments/sid/67624. Check the 'Dispatch' and 'Transfer' buttons are hidden, but a 'View Dispatch Request' button is displayed that links to the shipping service dispatch request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant