Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1528: Fix sorting on old summary page #883

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Dec 16, 2024

JIRA ticket: LIMS-1528

Summary:

The old data collection summary page is missing a few basic features, eg sorting and filtering

Changes:

  • Move lots of the logic from js to PHP
  • Remove essentially redundant columns, eg date, number of images, exposure time
  • Add some more useful columns eg Anom Completeness, CC1/2, CCanom
  • Add sorting by clicking on column headers
  • Remove weightings from top bar (not well understood), replace with filters

To test:

  • Go to a visit, then click the "Summary" button to go to eg /dc/summary/visit/mx37593-23
  • Check that a list of processed data collections appear
  • Check each header works to order the data collections, ascending then descending then reset. Some columns have multiple values, they usually sort by the first value shown, but resolution sorts by the lowest number shown
  • Check the filters at the top work to exclude data collections. By default it picks the best pipeline for each data collection, but if you choose a pipeline, it shows only that pipeline
  • Check the link to each data collection (magnifying glass icon) works
  • Check the download processing archive button (download icon) works
  • Check the search bar works on prefix and sample name
  • Check completeness values above 95 are green, above 80 are yellow, and below that red

@gfrn
Copy link
Collaborator

gfrn commented Dec 17, 2024

There is an unrelated issue, which I've mentioned before, where you cannot go to the summary page by pasting in the URL. But looks good to me, this issue is unrelated to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants