-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated Emotes from Impstation #2746
Open
hivehum
wants to merge
5
commits into
DeltaV-Station:master
Choose a base branch
from
hivehum:animated-emotes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+255
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
size/L
256-1023 lines
Changes: YML
Changes any yml files
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
and removed
S: Needs Review
size/L
256-1023 lines
labels
Jan 15, 2025
deltanedas
requested changes
Jan 15, 2025
deltanedas
previously approved these changes
Jan 16, 2025
Lyndomen
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the @flips? We are allergic to space flips. Thanks! Once that is all set, approval ops
Lyndomen
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
S: Needs Review
size/M
64-255 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This ports animated emotes, originally from Goob-Station/Goob-Station#828 but cleaned up by Impstation in impstation/imp-station-14#704, impstation/imp-station-14#757 and impstation/imp-station-14#1347, plus icon art from impstation/imp-station-14#1372
Why / Balance
Parity with SS13. Additionally it's an extremely charming and generally unobtrusive flavor addition to the game. Completely cosmetic.
Technical details
Adds AnimatedEmoteComponent + AnimatedEmotesSystem to support it as well as three emotes using the component. added the component to BaseMob and BaseGuardian (because holoparasites are not children of basemob for some reason).
Media
2025-01-15.16-10-11.mp4
Requirements
Breaking changes
N/A
Changelog
🆑 whateverusername0, AirFryerBuyOneGetOneFree, Darkmajia, hivehum, crocodilecarousel