Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Emotes from Impstation #2746

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hivehum
Copy link

@hivehum hivehum commented Jan 15, 2025

About the PR

This ports animated emotes, originally from Goob-Station/Goob-Station#828 but cleaned up by Impstation in impstation/imp-station-14#704, impstation/imp-station-14#757 and impstation/imp-station-14#1347, plus icon art from impstation/imp-station-14#1372

Why / Balance

Parity with SS13. Additionally it's an extremely charming and generally unobtrusive flavor addition to the game. Completely cosmetic.

Technical details

Adds AnimatedEmoteComponent + AnimatedEmotesSystem to support it as well as three emotes using the component. added the component to BaseMob and BaseGuardian (because holoparasites are not children of basemob for some reason).

Media

2025-01-15.16-10-11.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog

🆑 whateverusername0, AirFryerBuyOneGetOneFree, Darkmajia, hivehum, crocodilecarousel

  • add: Added two new animated emotes from Impstation: jump and spin.

@hivehum hivehum requested review from a team as code owners January 15, 2025 21:30
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files and removed S: Needs Review size/L 256-1023 lines labels Jan 15, 2025
@deltanedas
Copy link
Member

@BARKS macro secmains when they can have @flips macro:

@github-actions github-actions bot added the size/L 256-1023 lines label Jan 15, 2025
deltanedas
deltanedas previously approved these changes Jan 16, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the @flips? We are allergic to space flips. Thanks! Once that is all set, approval ops

@DeltaV-Station DeltaV-Station deleted a comment from flips Jan 16, 2025
@hivehum hivehum requested a review from Lyndomen January 16, 2025 17:31
@github-actions github-actions bot added size/M 64-255 lines and removed size/L 256-1023 lines labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants