new pens for various departments #2735
Conversation
github-actions
bot
added
S: Needs Review
size/M
|
RSI Diff Bot; head commit d627eba merging into cac28c6 Resources/Textures/_DV/Objects/Misc/pens.rsi
|
There was a problem hiding this comment.
Key points:
- Minor issues with the comments.
- Create a new
pen.ymlin it's respective folder in the_DVnamespace creating the pens you made there. - Create a new
pens.rsiin it's respective folder in the_DVnamespace, creating a new meta.json and adding the files you created there. - Minor convention issues on the pens.
| - type: Tending # Shitmed | ||
| speed: 0.55 | ||
| - type: SurgeryTool # Shitmed | ||
| startSound: | ||
| path: /Audio/_Shitmed/Medical/Surgery/retractor1.ogg | ||
| endSound: | ||
| path: /Audio/_Shitmed/Medical/Surgery/hemostat1.ogg |
There was a problem hiding this comment.
Restore this or explain why do you plan on removing this.
If you are trying to remove it you need to comment it out instead of deleting it,
|
ah- this code was made pre-shitmed and i ported old pen code back in, sorry about that lmao. i'll start working on fixing these. thanks for the review! |
No worries, i was just confused why it was nuked |
|
should be better now. do let me know if i've missed anything. thank you! |
| whitelist: | ||
| tags: | ||
| - Write | ||
| #end delta v content |
There was a problem hiding this comment.
Forgor to change to # End DeltaV changes
| @@ -125,4 +125,4 @@ | |||
| description: A luxurious fountain pen for the hop of the station. | |||
| components: | |||
| - type: Sprite | |||
| state: pen_hop | |||
| state: pen_hop | |||
There was a problem hiding this comment.
Add a end of file newline
There was a problem hiding this comment.
The JSON should be indented with 4 spaces instead of two.
Also you're missing an End of File newline.
|
forgot to untouch the json code. i'll do that when i get home 🤪 |
There was a problem hiding this comment.
JSON needs to be indented with four spaces. For an example check out the foam sabre meta.json
| #new delta v content | ||
| penSlot: | ||
| startingItem: PenPsych | ||
| priority: -1 | ||
| whitelist: | ||
| tags: | ||
| - Write | ||
| #end delta v content |
There was a problem hiding this comment.
The comments should be on the same indentation and should be formatted as such:
# Begin DeltaV changes
blah
blah
# End DeltaV changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
check out these cool and marketable pens! collect them all! sprites by kushbreth
About the PR
New pens have been added for:
Captain, HoP, HoS, Mystagogue, Logistics Officer, Chief Medical Officer, Chief Justice, Warden, and Psychologist.
Why / Balance
adds variety to standardized pens. fun little "rare" item. maybe someday they can be thief objectives but today is not that day.
Technical details
yaml changes.
Media
Requirements
Breaking changes
Changelog
🆑