Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

surgery and shitmed tweaks #2721

Merged
merged 26 commits into from
Jan 16, 2025
Merged

surgery and shitmed tweaks #2721

merged 26 commits into from
Jan 16, 2025
+63 −51

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Jan 14, 2025 •
edited
Loading

About the PR

more damage across the board really, tweaked sleep modifiers, less speed modifier for medical professionals.

please test this in a devenv and report how this feels, im not a surgery pro. Very open to feedback

Why / Balance

surgery overtuned especially remove bruise and burn

Technical details

yaml

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
🆑

  • tweak: Surgery now does a lil more damage! Keep your patients asleep!
  • tweak: Limbs have a lot more burn resist, and a lil less slash resist. Be careful!
  • tweak: Only Surgeon and CMO have a surgery buff, and it has been reduced dramatically.

@Lyndomen Lyndomen requested a review from a team as a code owner January 14, 2025 02:58
@github-actions github-actions bot added size/S 16-63 lines Changes: YML Changes any yml files S: Needs Review and removed size/S 16-63 lines labels Jan 14, 2025
Radezolid
Radezolid requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: DeltaV comment

Resources/Prototypes/_Shitmed/Entities/Surgery/surgery_steps.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_Shitmed/Entities/Surgery/surgery_steps.yml Show resolved Hide resolved
Resources/Prototypes/_Shitmed/Entities/Surgery/surgery_steps.yml Show resolved Hide resolved
Resources/Prototypes/_Shitmed/Entities/Surgery/surgery_steps.yml Show resolved Hide resolved
Resources/Prototypes/_Shitmed/Entities/Surgery/surgery_steps.yml Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/chemist.yml Outdated Show resolved Hide resolved
@Lyndomen
Copy link
Contributor Author

Re: why all the speed modifiers are the same. I don't personally like jobs just being instrinsically better than others at certain task. When we start relying on that as a balancing mechanic we have to start pretending getting hired into a job isn't real. I would prefer that the speed of an operation naturally comes from the skill of the character & player, rather than enforced by job

@Lyndomen
Copy link
Contributor Author

It's worth mentioning that this is not direction approved, not everyone agrees that job modifiers bad. Also have to find limb health

@deltanedas
Copy link
Member

i agree, CMO starts with advanced tools anyway so speed modifiers could be axed entirely and CMO would still be the fastest surgeon

@Lyndomen
Update chemist.yml
1eaf914 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@github-actions github-actions bot added the size/S 16-63 lines label Jan 14, 2025
@Lyndomen
Update chemist.yml
c99337d 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update chief_medical_officer.yml
3376b36 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update medical_doctor.yml
2cd5002 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@github-actions github-actions bot added size/M 64-255 lines and removed size/S 16-63 lines labels Jan 14, 2025
@Lyndomen
Update paramedic.yml
d3065c3 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update surgeon.yml
eeaa347 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update surgery_steps.yml
aa48cc2 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update belts.yml
b525683 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Copy link
Contributor Author

gave surgeon an advanced scalpel fo free because no more role modifiers

@Avalon-Proto
Copy link
Contributor

Does this PR do anything about the whole "Whoops you're on fire, time for your limbs to burn to ash in seconds"

@Radezolid
Copy link
Contributor

Does this PR do anything about the whole "Whoops you're on fire, time for your limbs to burn to ash in seconds"

Nope, it just modifies surgery values.

@Lyndomen
Copy link
Contributor Author

Does this PR do anything about the whole "Whoops you're on fire, time for your limbs to burn to ash in seconds"

it will when i get around to it

@Lyndomen Lyndomen requested a review from Radezolid January 15, 2025 05:13
Radezolid
Radezolid requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment changes and we are good

Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_DV/Roles/Jobs/Medical/surgeon.yml Outdated Show resolved Hide resolved
Lyndomen and others added 2 commits January 15, 2025 16:00
@Lyndomen @Radezolid
Update Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml
21c1606 
Co-authored-by: Radezolid <snappednexus@gmail.com>
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen @Radezolid
Update Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml
5a6007c 
Co-authored-by: Radezolid <snappednexus@gmail.com>
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
Radezolid
Radezolid requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not noticing these before.

Resources/Prototypes/Roles/Jobs/Medical/chemist.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Roles/Jobs/Medical/chemist.yml Outdated Show resolved Hide resolved
@Lyndomen
Update chemist.yml
9b309f0 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update chemist.yml
e26f372 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
Radezolid
Radezolid previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still needs some minor comments fixing but I will do that later.

@Lyndomen
Update chief_medical_officer.yml
ad897af 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update surgeon.yml
2c8c18c 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Copy link
Contributor Author

ok direction approved real

@Lyndomen
maybe ops
92f9fa2 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
whitespace
ab5fa3f 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
ples
3dda27c 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update base.yml
bf7569d 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update vox.yml
cb806ad 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update vulpkanin.yml
17466cb 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update rodentia.yml
f0fb78c 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Update chief_medical_officer.yml
cc82b50 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@Lyndomen
Merge branch 'master' into surgery-2
d66ccda
@Lyndomen
Copy link
Contributor Author

ok real

@Radezolid Radezolid merged commit 426b229 into DeltaV-Station:master Jan 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas left review comments

@Radezolid Radezolid Radezolid approved these changes

Assignees
No one assigned
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lyndomen @deltanedas @Avalon-Proto @Radezolid