Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: installation bug due to missing domain files #525

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Nov 14, 2023

Now the relevant files are included in the installation. Fixes #524

@gcroci2 gcroci2 requested a review from DaniBodor November 14, 2023 16:05
@gcroci2 gcroci2 self-assigned this Nov 14, 2023
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the last few lines of some of the files was duplicated. Can you remove those before merging, please.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't every folder supposed to have an init.py file? Not sure why, but I thought that was the case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the official documentation, it seems that it's not needed.

tests/utils/test_exporters.py Outdated Show resolved Hide resolved
tests/utils/test_grid.py Outdated Show resolved Hide resolved
tests/molstruct/test_structure.py Outdated Show resolved Hide resolved
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Nov 16, 2023

for some reason the last few lines of some of the files was duplicated. Can you remove those before merging, please.

Thanks for noticing, no clue about what happened. It's fixed now :)

@gcroci2 gcroci2 merged commit ca9dd46 into main Nov 17, 2023
7 checks passed
@gcroci2 gcroci2 deleted the hotfix_gcroci2 branch November 17, 2023 09:05
@gcroci2 gcroci2 added the JOSS label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tutorial failing when running deeprank2 as Dockerfile
2 participants