-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add performances table for deeprank2 #493
Conversation
I will take a closer look at this, but for now already a few comments: I feel that this should be much lower in the README, maybe just before the Package Development header. It's nice information to have there, but most users will not care that much, so it shouldn't be something they need to scroll past before getting to the information they are looking for.
Yes, I would create a subfolder performance/, probably in tools.
Definitely out of the scope of this PR/the JOSS paper
I think it's actually the same format, just a different extension. If you just replace the extension with .pdb, I think it should work. Not sure whether it's worth the effort though. |
Agreed, I moved it down
Indeed it worked :) I updated the results Regarding the location of the perf scripts, I created perf/ in tests/ and I placed them there. The reason why I don't want to put them into the package is that they are not tested (and doesn't make sense to test them in my opinion), and they will increase lines of code of the package while decreasing the overall coverage. Also they're not something that we wish is installed together with the package. I'm still not sure of the best place for them, but I'd say not in deeprank2/ code base folder. |
Co-authored-by: Dani Bodor <d.bodor@esciencecenter.nl>
Co-authored-by: Dani Bodor <d.bodor@esciencecenter.nl>
I am using the same PDB raw data used in the tutorials (see https://zenodo.org/record/8187806).
conservation
features module)conservation
)