blank node fix for hdt implmentation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d implementation. Converted functions to use generics for the DatasetView trait. Code compiles.
…s to the new traits to avoid the use of ugly &(*dataset) versus simple &dataset parameters to function calls.
…f.dataset parameters to function calls.
…an HDT file successfully.
…nket implementations of &T and Rc<T>. Updated the HDT test driver to open the HDT only once and reuse the dataset instance via Rc<HDTDatasetView>.
…o output CSV. Updated the HDT/OxRDF transformations to use NamedNode.into_string() and Term::from_str() where possible.
…. CLI tests are still failing.
…ker errors when ld is used instead of the LLVM lld linker. It seems that rustc is using 'cc' as the driver for the linker. On Intel DevCloud update-alternatives --config cc cannot be changed from gcc. Forcing lld for consistency with the Intel Compiler LLVM-based toolset seems to work around the problem. Note that compiling everything with LLVM/clang/Intel and linking with LLVM's lld appears to be the foundation for getting working binaries. It was also observed that some tests collide with each other when run in parallel. Limiting to --jobs 1 when running tests works around that problem.
…r from config.toml to build-devcloud.sh as environment variables so that it does not interfere with other build tools.
…r from config.toml to build-devcloud.sh as environment variables so that it does not interfere with other build tools.
…rage. WIP for Issue #1 to compile with upstream changes from main.
… the hdt_driver crate. Moved test resources into a dedicated directory. Updated build-devcloud.sh to use a removable subdirectory to support the cargo clean command. Updated path to test resources to use a relative path to the new locations.
…se need to be generalized to make use of the manifest files from the W3C test suite.
…es from Git for the test cases since those are generated as needed. Fixed W3C SPARQL Basic data-3 HDT test data file. Verified W3C SPARQL 1.0 Basic tests all pass.
…set with two tests excluded per their exclusion in Oxigraph.
…. Additional implementation is needed to load and query from multiple HDT files at once.
…W3C SPARQL 1.0 Query Test suite.
…ry test suite. Added ignored graph tests due to lack of named graphs support in HDT. Added placeholder for dataset tests.
This reverts commit 1ffc01d.
…is not found to clarify that it is the HDT file rather than another file. Added additional W3C SPARQL 1.0 Query test cases. Updated the SPARQL query of the test metadata to output strings close to what the Rust test macro expects.
…xcluding 'dataset', use of named graphs, and tests already excluded by Oxigraph.
GregHanson
changed the title
GregHanson
force-pushed
the
1-enable-sparql-query-of-hdt-storage
branch
from
d728026 to
2d6246a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.