Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Channelised Data Quality (lofar_cli_stokes.c) #11

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

David-McKenna
Copy link
Owner

@David-McKenna David-McKenna commented May 15, 2023

Increases channelised data quality through the user of overlapping data in FFT windows, using smaller FFT windows for increased performance, and adding a baseline support for pulsar coherent dedispersion

TODO:

  • Non-even channelisation factor support
    • Will probably achieve this by removing access to packetsPerIteration, and controlling it based on the requested input
  • General code cleanup/documentation (cleanup done, documentation needed)
  • Move debug information to the verbose flag
  • Fix the no-metadata segfault when it attempts to calculate associated frequencies (how did this get past the tests?)
  • Correlated voltages output mode for faster generation than DADA/digifil glue
  • [~] Account for partial reads in the end block (accounted for by just exiting. Not great, but it'll work.)
    • Get all useful data in the last block, up to the last full FFT operation. This will require adjusting the input parameters for overlapAndPad, for both "intended" and "real input" dimensions. Maybe split it into a new func call?
  • Add metadata overrides for nbit, processing mode to silence warnings

@David-McKenna David-McKenna self-assigned this May 15, 2023
@David-McKenna David-McKenna force-pushed the stokesChannelisationFixes branch from a507a82 to cd4b77b Compare June 30, 2023 16:31
…st iteration, working to isolate the segfaults for low values of "-B"
…Iteration

For some reason, despite an explicit set to NULL, this was being treated as a true statement in Release mode.
For some reason, when present they cause the wrong branch to be taken for the inner beamletJones if statement
@David-McKenna David-McKenna force-pushed the stokesChannelisationFixes branch from 0b2cd6c to b9e7836 Compare July 3, 2023 14:46
David-McKenna and others added 30 commits July 6, 2023 15:35
Set a default number of threads if the CPU probe fails
Account for nested builds in the custom bitshuffle Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant