-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Channelised Data Quality (lofar_cli_stokes.c) #11
Draft
David-McKenna
wants to merge
67
commits into
main
Choose a base branch
from
stokesChannelisationFixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-McKenna
force-pushed
the
stokesChannelisationFixes
branch
from
June 30, 2023 16:31
a507a82
to
cd4b77b
Compare
…st iteration, working to isolate the segfaults for low values of "-B"
…e headerBuffer in Stokes CLI
…r segfault on 4-bit data before?)
…Iteration For some reason, despite an explicit set to NULL, this was being treated as a true statement in Release mode.
For some reason, when present they cause the wrong branch to be taken for the inner beamletJones if statement
David-McKenna
force-pushed
the
stokesChannelisationFixes
branch
from
July 3, 2023 14:46
0b2cd6c
to
b9e7836
Compare
…I completely missed this)
…need call on read
Set a default number of threads if the CPU probe fails Account for nested builds in the custom bitshuffle Makefile
…ut does locally?)
…r PSRDADA when upm is a subproject
… default install target
…stall step instead
…for BUILD_BYPRODUCTS is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases channelised data quality through the user of overlapping data in FFT windows, using smaller FFT windows for increased performance, and adding a baseline support for pulsar coherent dedispersion
TODO: