Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: Enable 128bit trace ID logging by default #3086

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mtoffl01
Copy link
Contributor

What does this PR do?

Logs the full 128bits of the trace id by default. Can be disabled with DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=false.

Motivation

Config consistency

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 changed the title ddtraace/tracer: Enable 128bit trace ID logging by default ddtrace/tracer: Enable 128bit trace ID logging by default Jan 14, 2025
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 14, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 14, 2025

Datadog Report

Branch report: mtoff/log-128bit-enabled
Commit report: a17b52a
Test service: dd-trace-go

✅ 0 Failed, 5174 Passed, 71 Skipped, 2m 35.42s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-15 19:08:36

Comparing candidate commit b08de4b in PR branch mtoff/log-128bit-enabled with baseline commit 471d723 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@mtoffl01 mtoffl01 marked this pull request as ready for review January 15, 2025 19:30
@mtoffl01 mtoffl01 requested review from a team as code owners January 15, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant