internal: add supported versions for v2 #3070
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 4084 Passed, 64 Skipped, 2m 49.72s Total Time |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| # note: This will only run when there *are* changes to integration versions | ||
| - name: Create Pull Request | ||
| id: pr | ||
| uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
BenchmarksBenchmark execution time: 2025-01-15 17:58:09 Comparing candidate commit 8ce43a8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. |
quinna-h
changed the title
| @@ -844,3 +844,11 @@ func isAWSMessagingSendOp(awsService, awsOperation string) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| func GetPackages() map[Package]string { | |||
There was a problem hiding this comment.
@darccio @rarguelloF what do you think? I changed this to return a deep copy, and only store the values we need to use
There was a problem hiding this comment.
looks good to me, but in case you want the other public fields as well, you can use the json.Marshal / json.Unmarshal trick to do it easily (it's not performant at all, but for this use case it should be good enough)
github-actions
bot
added
the
apm:ecosystem
What does this PR do?
contrib/<package_name>/go.mod, and the maximum version from github.- This fetches the maximum from
go list -m -u -json <repositorycontrib/supported_versions.mdwith the module name, repository, minimum and maximum versions supported, and whether it is auto-instrumented using this definition: https://github.com/DataDog/orchestrion#supported-librariesMotivation
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!