Made custom data in layouts typed #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBeekman
commented
Oct 31, 2023
| @@ -14,7 +14,23 @@ namespace RGB.NET.Layout; | |||
| /// </summary> | |||
| [Serializable] | |||
| [XmlRoot("Device")] | |||
| public class DeviceLayout : IDeviceLayout | |||
| public class DeviceLayout : DeviceLayout<object, object> | |||
There was a problem hiding this comment.
I'm not a 100% sure on this, it's a nice shortcut to deal with layouts if you're not interested in custom data but it creates this scenario, which confused me a bit at first:
DeviceLayout layoutA = new DeviceLayout();
DeviceLayout<object, object> layoutB = new DeviceLayout<object, object>();
layoutA = layoutB; // not possible as DeviceLayout<object, object> is technically a subtype of DeviceLayout
layoutB = layoutA; // possible because DeviceLayout is a derived type of DeviceLayout<object, object>
|
Turns out the layout editor is just stupid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on layout support in the Artemis workshop but I'm having some struggles serializing layouts.
The layout editor 'solves' this problem using this monstrosity: https://github.com/RobertBeekman/RGB.NET-Layout-Editor/blob/a91c944fedbcf320bdf0be2a25fbc267798a91af/src/LayoutEditor.UI/Pages/DeviceLayoutEditorViewModel.cs#L131C14-L131C14
I'd rather not adapt that for Artemis though, since I feel like the manual XML manipulation is a bit much.
To that end looked into what can be done to simplify things and I landed on this (sadly breaking) change.