Merge pull request #403 from stonstad/Contributions

Remove CustomUpdateData heap allocation in OnUpdate hot path.
DarthAffe · Nov 3, 2024 · 71f1115 · 71f1115
2 parents a26eaf9 + da51871
commit 71f1115
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/RGB.NET.Core/Update/AbstractUpdateTrigger.cs b/RGB.NET.Core/Update/AbstractUpdateTrigger.cs
@@ -29,13 +29,13 @@ public abstract class AbstractUpdateTrigger : AbstractBindable, IUpdateTrigger
     /// Invokes the <see cref="Starting"/>-event.
     /// </summary>
     /// <param name="updateData">Optional custom-data passed to the subscribers of the <see cref="Starting"/>.event.</param>
-    protected virtual void OnStartup(CustomUpdateData? updateData = null) => Starting?.Invoke(this, updateData ?? new CustomUpdateData());
+    protected virtual void OnStartup(CustomUpdateData? updateData = null) => Starting?.Invoke(this, updateData ?? CustomUpdateData.Empty);
 
     /// <summary>
     /// Invokes the <see cref="Update"/>-event.
     /// </summary>
     /// <param name="updateData">Optional custom-data passed to the subscribers of the <see cref="Update"/>.event.</param>
-    protected virtual void OnUpdate(CustomUpdateData? updateData = null) => Update?.Invoke(this, updateData ?? new CustomUpdateData());
+    protected virtual void OnUpdate(CustomUpdateData? updateData = null) => Update?.Invoke(this, updateData ?? CustomUpdateData.Empty);
 
     /// <inheritdoc />
     public abstract void Start();

diff --git a/RGB.NET.Core/Update/CustomUpdateData.cs b/RGB.NET.Core/Update/CustomUpdateData.cs
@@ -52,6 +52,9 @@ public sealed class CustomUpdateData : ICustomUpdateData
 {
     #region Properties & Fields
 
+    // ReSharper disable once InconsistentNaming
+    public static readonly CustomUpdateData Empty = new();
+
     private readonly Dictionary<string, object?> _data = [];
 
     #endregion