Allow for multiple now and next events #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for multiple now and next events in the response types used in the client and adapter. It does not allow the client to return multiple now/next events or allow the CLI to display them, this will be done later. Multiple events should not really be a common issue, but it did happen in 2022, so might happen again, who knows. May as well handle it correctly if it does happen though. Re #13
DanNixon
force-pushed
the
now-next-multiple
branch
from
0f9c4d2 to
e84947e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for multiple now and next events in the response types used in the client and adapter.
It does not allow the client to return multiple now/next events or allow the CLI to display them, this will be done later.
Multiple events should not really be a common issue, but it did happen in 2022, so might happen again, who knows.
May as well handle it correctly if it does happen though.
Re #13
cc @IainYa