Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added __init__.py file to the services directory. Changed is not to != when comparing to a string. #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2021

After running pip install python-test-bed-adapter the resulting package (v0.0.6) was missing the services directory. Presumably (based on #5) this is caused by a missing __init__.py file.

I've added the file to the services directory.

Additionally I got a warning when running import test_bed_adapter:

...\site-packages\test_bed_adapter\services\time_service.py:74: SyntaxWarning: "is not" with a literal. Did you mean "!="?

As a string is compared the != is more appropriate here (I think).

b-a0 added 2 commits February 10, 2021 23:11
Changed `is not` to != when comparing to a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant