Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mount the cgroup as read-only #194

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Don't mount the cgroup as read-only #194

merged 1 commit into from
Jul 7, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Jul 7, 2024

Fixes: #193

I wonder why we never had this in the past as we do intent to create the domjudge cgroup in that directory.

@vmcj
Don't mount the cgroup as read-only
e3f1501 
Fixes: #193

I wonder why we never had this in the past as we do intent to create the domjudge cgroup in that directory.
nickygerritsen
nickygerritsen approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to work even if it was read only but something changed in docker and now we require rw

@vmcj vmcj added this pull request to the merge queue Jul 7, 2024
Merged via the queue into main with commit 2608426 Jul 7, 2024
2 checks passed
@vmcj vmcj deleted the documentation-update-docker-cgroup branch July 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

judgehost: create_cgroups fails when /sys/fs/cgroup is mounted with read-only option
2 participants
@vmcj @nickygerritsen