Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI #19

Draft
wants to merge 1 commit into
base: noetic
Choose a base branch
from
Draft

Add GitHub Actions CI #19

wants to merge 1 commit into from

Conversation

mintar
Copy link
Member

@mintar mintar commented Jan 30, 2023

No description provided.

@mintar
Copy link
Member Author

mintar commented Jan 30, 2023

Running the tests currently takes 39 minutes (9 minutes for install-deps.sh, 29 minutes for catkin build), because the whole mobipick stack and all its dependencies are cloned and built. To make this viable, we should reduce this time by a lot (like with the Docker method that's currently used in the mobipick gitlab CI).

Also, a test in robot_api is currently failing; reported at https://git.ni.dfki.de/acting/robot_api/-/merge_requests/13 .

@brean
Copy link
Contributor

brean commented Feb 11, 2023

Can't you provide a docker image with some basics (at least the mir-100 stack or an image that has already called install-deps.sh) and not rebuild everything all the time?

@mintar
Copy link
Member Author

mintar commented Feb 13, 2023

Can't you provide a docker image with some basics (at least the mir-100 stack or an image that has already called install-deps.sh) and not rebuild everything all the time?

Yes, that's what I meant with "the Docker method that's currently used in the mobipick gitlab CI" (that sentence was more a note for myself and thus a little cryptic). What it means is: For the mobipick repository, I build a Docker image only whenever the dependencies change (takes around 25 minutes), and then the regular builds are quick and not as error-prone (take around 2-3 minutes):

https://github.com/DFKI-NI/mobipick/blob/d984fc221147301a741854a3736d20190c3d2b6a/.gitlab-ci.yml

However, this currently only runs in the fork of mobipick on our private GitLab instance, not on GitHub yet. I just haven't had time yet to convert that to GitHub actions, and then build on top of that for the mobipick_labs repo. Pull requests welcome! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants