feat: Add HTTP_NOT_FOUND constant and use it in dts-process.js

DEFRA · May 8, 2024 · 8f36696 · 8f36696
1 parent 85fc569
commit 8f36696
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/functions/imtd-process.js b/lib/functions/imtd-process.js
@@ -5,6 +5,7 @@ const pg = require('../helpers/db')
 const invokeLambda = require('../helpers/invoke-lambda')
 const deleteThresholds = require('../helpers/imtd-api').deleteStation
 const tableName = 'station_imtd_threshold'
+const { HTTP_NOT_FOUND } = require('../constants')
 
 async function insertThresholds (stationId, thresholds) {
   try {
@@ -34,7 +35,7 @@ async function getImtdApiResponse (stationId) {
   try {
     return await axios.get(`https://${hostname}/Location/${stationId}?version=2`)
   } catch (error) {
-    if (error.response?.status === 404) {
+    if (error.response?.status === HTTP_NOT_FOUND) {
       logger.info(`Station ${stationId} not found (HTTP Status: 404)`)
     } else {
       const message = error.response?.status ? `HTTP Status: ${error.response.status}` : `Error: ${error.message}`

diff --git a/lib/models/rloi.js b/lib/models/rloi.js
@@ -24,7 +24,7 @@ function removePostfix (name) {
 }
 
 async function fetchStation (s3, bucket, key) {
-  return await s3.getObject({
+  return s3.getObject({
     Bucket: bucket,
     Key: key
   })