Develop #1
Open
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaperst
reviewed
Oct 22, 2018
| @@ -44,6 +44,8 @@ | |||
| android:layout_marginRight="8dp" | |||
| android:layout_marginBottom="8dp" | |||
| android:text="Training" | |||
| android:textAllCaps="false" | |||
There was a problem hiding this comment.
Isn't there a way to define all of these properties as a default set, so you don't need to redefine these each time?
There was a problem hiding this comment.
not sure what you mean.
There was a problem hiding this comment.
@msaperst i think maybe in the style/themes you can set a style that can be used by all buttons or something if thats what you mean
| @@ -4,4 +4,7 @@ | |||
| <color name="colorPrimaryDark">#2e0057</color> | |||
| <color name="colorAccent">#D81B60</color> | |||
| <color name="white">#ffffffff</color> | |||
| <color name="coverosPrimary">#276bcf</color> | |||
| <color name="hintColorPink">#ffff25e6</color> | |||
There was a problem hiding this comment.
This looks wrong, why 8 chars, not 6?
There was a problem hiding this comment.
idk, the color showed up, i just used the color scale thing and picked the color which gave me the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.