8934 inclusion list pool #9013
Merged
8934 inclusion list pool #9013
+75
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
added a commit
that referenced
this pull request
Jan 17, 2025
* add inclusion list pool skeleton
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Override | ||
| public synchronized void onSlot(final UInt64 slot) {} | ||
|
|
||
| public void add(final SignedInclusionList signedInclusionList) {} |
Check notice
Code scanning / CodeQL
Useless parameter Note
| return SafeFuture.completedFuture(InternalValidationResult.ACCEPT); | ||
| } | ||
|
|
||
| public List<SignedInclusionList> getInclusionLists(final UInt64 slot) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add InclusionListPool skeleton
Fixed Issue(s)
fixes #8934
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog