Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidatorIndexProviderTest for Apple M4 #9010

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Jan 17, 2025

PR Description

I assume that order is not guaranteed here and it was working because of good luck (read: java machine implementations). Alternatively we could add sorting in provider if it makes a sense.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Was passing fine with corretto-22 but fails with corretto-23

@zilm13 zilm13 merged commit 671cd35 into Consensys:master Jan 17, 2025
16 checks passed
@zilm13 zilm13 deleted the fix-test-m4-ordering branch January 17, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants