Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve builder client logging #9002

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Improve builder client logging #9002

merged 2 commits into from
Jan 16, 2025
+7 −5

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Jan 16, 2025 •
edited
Loading

It also adds the missing change log line

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

mehdi-aouadi
mehdi-aouadi approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) January 16, 2025 12:31
@tbenr tbenr merged commit 477080a into master Jan 16, 2025
18 checks passed
@tbenr tbenr deleted the improve-builder-client-logging branch January 16, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-aouadi mehdi-aouadi mehdi-aouadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @mehdi-aouadi