Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve electra attestation aggregation #8346

Merged
merged 8 commits into from
May 30, 2024
Merged

Improve electra attestation aggregation #8346

merged 8 commits into from
May 30, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 29, 2024 •
edited
Loading

  • avoid recalculating starting positions when can be avoided (improved performance in calculation too)
  • improved lookup to last bit set in committee bits
  • avoid triggering ssz hashing on committee bits in isSuperSetOf
  • rewrote or, now is ~4x faster and consumes far less memory
    • added SszBitlist wrapBitSet constructor to operate directly with a bitSet
  • improved tests

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) May 30, 2024 12:47
@tbenr tbenr merged commit 568aef5 into Consensys:master May 30, 2024
16 checks passed
@tbenr tbenr deleted the improve-electra-attestation-aggregation branch May 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @StefanBratanov