Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing final #8342

Merged
merged 2 commits into from
May 29, 2024
Merged

Add missing final #8342

merged 2 commits into from
May 29, 2024

Conversation

gfukushima
Copy link
Contributor

PR Description

ADding some missing final in order to get MethodInputParametersMustBeFinal enabled in the project

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

gfukushima added 2 commits May 28, 2024 13:30
@gfukushima
Add final
3cca306 
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima
undo unwanted change
4154fb5 
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima changed the title Final part 2 Add missing final May 28, 2024
@gfukushima gfukushima merged commit 9522d35 into Consensys:master May 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfukushima @rolfyone