Enhanced IPv6 support (libp2p)

[StefanBratanov]

PR Description

Add new options (hidden for now until discovery is adapted for dual stack as well):

• --Xp2p-port-ipv6
• --Xp2p-advertised-port-ipv6

Also enhanced --p2p-interface and --p2p-advertised-ip to accept multiple entries to support dual-stack (IPv4 and IPv6), but for the moment didn't add changes to description until we unhide the ipv6 feature entirely.

Testing (dual stack)

13:49:11.601 INFO  - Listening for connections on: /ip4/127.0.0.1/tcp/9000/p2p/16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS,/ip6/2a01:4b00:875c:9500:d55c:71df:3af7:9f1f/tcp/9090/p2p/16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS

Response from eth/v1/node/identity

{
  "data": {
    "peer_id": "16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS",
    "enr": "enr:-LK4QL4QeqrRSLtOvXSW4n1IstncRls_CPhhrBzPiOG4yAXlWtXq2GqAFXk2kC_Cxne7QH7F-mkjxvcnhI6zt8ySdHUEh2F0dG5ldHOIBgAAAAAAAACEZXRoMpBqlaGpBAAAAP__________gmlkgnY0gmlwhH8AAAGJc2VjcDI1NmsxoQLIl2CHsAAMhZN_Jmh_Tr3dM9huh4cYFN0_ItPq9XBwv4N0Y3CCIyiDdWRwgiMo",
    "p2p_addresses": [
      "/ip4/127.0.0.1/tcp/9000/p2p/16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS",
      "/ip6/2a01:4b00:875c:9500:d55c:71df:3af7:9f1f/tcp/9090/p2p/16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS"
    ],
    "discovery_addresses": [
      "/ip4/127.0.0.1/udp/9000/p2p/16Uiu2HAm8vhQ3odDV2YkNFH5ZE2HmCEFX1Q83nSX3fLRroinQdtS"
    ],
    "metadata": {
      "seq_number": "1",
      "attnets": "0x0600000000000000",
      "syncnets": "0x00"
    }
  }
}

Fixed Issue(s)

related to #8069

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[tbenr]

have you tried single stack ipV6 ? Discovery won't work but we should be able to run over outbound connections only.

[StefanBratanov]

have you tried single stack ipV6 ? Discovery won't work but we should be able to run over outbound connections only.

Yes. Discovery still works though. It doesn't support dual-stack but works with single stack IPv6.

[tbenr]

One thing that does not convince me is that we are leaking the feature via --p2p-advertised-ips and --p2p-interfaces aliases but then we hide the v6 options via --X. Maybe you're right but i'd like to discuss it

[tbenr]

Sorry I didn't mean to "request changes", I pressed the wrong button on intelliJ :)

Pressed wrong button

[tbenr]

LGTM. with a doubt