Added config items for late block reorg #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `REORG_HEAD_WEIGHT_THRESHOLD`, `REORG_PARENT_WEIGHT_THRESHOLD`, and `REORG_MAX_EPOCHS_SINCE_FINALIZATION` to phase0 configuration, and defaulted - added utility functions: - `isShufflingStable` - `isFinalizationOk` - `calculateCommitteeFraction` which were part of the changes in ethereum/consensus-specs#3034 partially addresses Consensys#6595 Signed-off-by: Paul Harris <paul.harris@consensys.net>
lucassaldanha
approved these changes
Nov 16, 2023
ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigPhase0.java
Outdated
Show resolved
Hide resolved
ethereum/spec/src/test/java/tech/pegasys/teku/spec/logic/common/util/ForkChoiceUtilTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
REORG_HEAD_WEIGHT_THRESHOLD,REORG_PARENT_WEIGHT_THRESHOLD, andREORG_MAX_EPOCHS_SINCE_FINALIZATIONto phase0 configuration, and defaultedadded utility functions:
isShufflingStableisFinalizationOkcalculateCommitteeFractionwhich were part of the changes in ethereum/consensus-specs#3034
partially addresses #6595
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog