improvements

ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/attestation/utils/AttestationBitsAggregatorElectraTest.java

@@ -393,45 +393,6 @@ void bigAggregation() {
         .isEqualTo(result.getAttestation().getAggregationBits());
   }
 
-  @Test
-  void asd() {
-    committeeSizes = new Int2IntOpenHashMap();
-    IntStream.range(0, 64).forEach(i -> committeeSizes.put(i, 600));
-
-    List<Integer> committee1 =
-        IntStream.range(0, 64).mapToObj(__ -> dataStructureUtil.randomPositiveInt(64)).toList();
-    int[] aggregation1 =
-        IntStream.range(0, 600).map(__ -> dataStructureUtil.randomPositiveInt(600)).toArray();
-
-    List<Integer> committee2 =
-        IntStream.range(0, 64).mapToObj(__ -> dataStructureUtil.randomPositiveInt(64)).toList();
-    int[] aggregation2 =
-        IntStream.range(0, 600).map(__ -> dataStructureUtil.randomPositiveInt(600)).toArray();
-
-    ValidatableAttestation asd = createAttestation(committee1, aggregation1);
-
-    committee2 = committee1.subList(0, committee1.size() - 1);
-
-    ValidatableAttestation asd2 = createAttestation(committee2, aggregation2);
-    final AttestationBitsAggregator aggregator = AttestationBitsAggregator.of(asd);
-
-    long now = System.currentTimeMillis();
-    for (int i = 0; i < 100000; i++) {
-      aggregator.or(asd2.getAttestation());
-    }
-    long finalTime = System.currentTimeMillis() - now;
-    System.out.println("time: " + finalTime + " ms - ops per millisecond: " + 100000f / finalTime);
-
-    //     now = System.currentTimeMillis();
-    //    for(int i = 0; i < 10000; i++) {
-    //
-    // asd2.getAttestation().getAggregationBits().or(asd.getAttestation().getAggregationBits());
-    //    }
-    //     finalTime = System.currentTimeMillis() - now;
-    //    System.out.println("time: " + finalTime + " ms - ops per millisecond: " + 10000f /
-    // finalTime);
-  }
-
   @Test
   void isSuperSetOf1() {
 

infrastructure/ssz/src/main/java/tech/pegasys/teku/infrastructure/ssz/schema/collections/SszBitlistSchema.java

@@ -31,5 +31,14 @@ default SszBitlistT empty() {
 
   SszBitlistT ofBits(int size, int... setBitIndices);
 
+  /**
+   * Creates a SszBitlist by wrapping a given bitSet. This is an optimized constructor that DOES NOT
+   * clone the bitSet. It used in aggregating attestation pool. DO NOT MUTATE the after the
+   * wrapping!! SszBitlist is supposed to be immutable.
+   *
+   * @param size size of the SszBitlist
+   * @param bitSet data backing the ssz
+   * @return SszBitlist instance
+   */
   SszBitlistT wrapBitSet(int size, BitSet bitSet);
 }

infrastructure/ssz/src/test/java/tech/pegasys/teku/infrastructure/ssz/collections/SszBitlistTest.java

@@ -135,6 +135,28 @@ void testWrapBitSet(SszBitlist bitlist1) {
     assertThat(bitlist2.sszSerialize()).isEqualTo(bitlist1.sszSerialize());
   }
 
+  @Test
+  void wrapBitSet_shouldDropBitsIfBitSetIsLarger() {
+    final BitSet bitSet = new BitSet(100);
+    bitSet.set(99);
+    assertThat(bitSet.stream().count()).isEqualTo(1);
+
+    final SszBitlist sszBitlist = schema.wrapBitSet(10, bitSet);
+    final SszBitlist expectedSszBitlist = schema.ofBits(10);
+
+    assertThat(sszBitlist).isEqualTo(expectedSszBitlist);
+    assertThat(sszBitlist.hashCode()).isEqualTo(expectedSszBitlist.hashCode());
+    assertThat(sszBitlist.hashTreeRoot()).isEqualTo(expectedSszBitlist.hashTreeRoot());
+    assertThat(sszBitlist.sszSerialize()).isEqualTo(expectedSszBitlist.sszSerialize());
+  }
+
+  @Test
+  void wrapBitSet_shouldThrowIfSizeIsLargerThanSchemaMaxLength() {
+    assertThatThrownBy(
+            () -> schema.wrapBitSet(Math.toIntExact(schema.getMaxLength() + 1), new BitSet()))
+        .isInstanceOf(IllegalArgumentException.class);
+  }
+
   @ParameterizedTest
   @MethodSource("bitlistArgs")
   void testTreeRoundtrip(SszBitlist bitlist1) {