Fix builder http leak (#9011)

Consensys · Jan 17, 2025 · 40b2f8f · 40b2f8f
1 parent 671cd35
commit 40b2f8f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...rc/main/java/tech/pegasys/teku/ethereum/executionclient/rest/AbstractResponseHandler.java b/...rc/main/java/tech/pegasys/teku/ethereum/executionclient/rest/AbstractResponseHandler.java
@@ -38,7 +38,7 @@ protected <T> boolean handleResponseError(
     if (response.isSuccessful()) {
       return false;
     }
-    try {
+    try (response) {
       if (response.code() == SC_UNSUPPORTED_MEDIA_TYPE) {
         futureResponse.complete(Response.fromUnsupportedMediaTypeError());
       } else {

diff --git a/...nt/src/main/java/tech/pegasys/teku/ethereum/executionclient/rest/ResponseHandlerVoid.java b/...nt/src/main/java/tech/pegasys/teku/ethereum/executionclient/rest/ResponseHandlerVoid.java
@@ -31,6 +31,7 @@ void handleResponse(final Request request, final okhttp3.Response response) {
     if (handleResponseError(request, response, futureResponse)) {
       return;
     }
+    response.close();
     futureResponse.complete(Response.fromNullPayload());
   }
-Original file line number
+Diff line change
@@ Expand Up @@
         if (handleResponseError(request, response, futureResponse)) {
           return;
         }
+        response.close();
         futureResponse.complete(Response.fromNullPayload());
       }
@@ Expand Down @@