[Desktop] Add native win32 / linux custom window #2228
Conversation
This reverts commit 4461067.
Co-Authored-By: Chenlei Hu <hcl@comfy.org>
This reverts commit 30cd46c.
This reverts commit 8f5aa1f.
This reverts commit e076783.
This reverts commit 04c2300. - No change to BaseViewTemplate - No change to mock electronAPI
- No longer requires app restart on window style change
Minor UX concern that can be looked at later.
webfiltered
changed the title
webfiltered
requested review from
Yorha4D,
KarryCharon,
DorotaLuna,
shinshin86 and
a team
as code owners
There was a problem hiding this comment.
There are a few concerns:
Virtual Title Bar
Why we want to drop the virtual titlebar design? The virtual titlebar matches the user intuition. While making custom draggable area for each view seems wrong to me. I made the BaseViewTemplate specifically to address the issue that we need to specify draggable area for each view.
Ref: Window settings window draggable area:
Bottom menu location
Is there any reason why we want to drop the support for bottom menu location? Current design supports the location while the PR drops it.
| }) | ||
| } | ||
| }) | ||
| /** Height of titlebar on desktop. */ |
There was a problem hiding this comment.
I don' think the resize observer is necessary after #2209 as the topbar menu height is now fixed.
|
|
||
| <style lang="postcss"> | ||
| /* Desktop: Custom window styling */ | ||
| :root[data-platform='electron'] { |
There was a problem hiding this comment.
Why are we restoring the logo change? I don't think that is something we want to ship:
- Our current logo looks bad at icon scale.
- On-going new logo design.
-
- Taking up extra space on the menu bar with no extra benefit provided.
There was a problem hiding this comment.
Just a summary of points elsewhere:
Design-wise, there is an expectation of an icon / logo in the top left corner. It's very hard to find any apps that do not have an icon of some kind as the top left part of their window. Apps with just text in the very top left corner feel incomplete or cut off.
There is a lot of overlap between this PR and the reverted PRs, but it was significantly less effort to get the features I wanted to reimpl. from #1856 this way.
Behaviour differences
UseNewMenuisBottomorDisabled,the custom window mode is set todefaultcustomwindow style is selected,UseNewMenuis set toTopCode changes
App.vueResizeObserver┆Issue is synchronized with this Notion page by Unito