Support custom SaveImage nodes when registering SaveImageExtraOutput #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the conditional logic to use `includes` for matching `SaveImage` node variants. This ensures broader compatibility with nodes sharing similar naming conventions while maintaining functionality for `SaveAnimatedWEBP`.
Ensure that widget existence is verified before assigning `serializeValue`. This prevents potential runtime errors when the widget is undefined. This guards against any custom nodes that name match but don't have the provided field from throwing an error.
huchenlei
approved these changes
Jan 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
HaydenReeve
commented
Jan 14, 2025
| @@ -7,7 +7,7 @@ import { applyTextReplacements } from '../../scripts/utils' | |||
| app.registerExtension({ | |||
| name: 'Comfy.SaveImageExtraOutput', | |||
| async beforeRegisterNodeDef(nodeType, nodeData, app) { | |||
| if (nodeData.name === 'SaveImage' || nodeData.name === 'SaveAnimatedWEBP') { | |||
| if (nodeData.name.includes('SaveImage') || nodeData.name === 'SaveAnimatedWEBP') { | |||
There was a problem hiding this comment.
Would you like me to fix the prettier issue while I'm here?
I believe the change is
Suggested change
| if (nodeData.name.includes('SaveImage') || nodeData.name === 'SaveAnimatedWEBP') { | |
| if ( | |
| nodeData.name.includes('SaveImage') || | |
| nodeData.name === 'SaveAnimatedWEBP' | |
| ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the conditional logic to use
includesfor matchingSaveImagenode variants. This ensures broader compatibility with nodes sharing similar naming conventions while maintaining functionality forSaveAnimatedWEBP.Resolves #2218
This PR seeks to extend some support for custom
SaveImagenodes so that they may also make use of the rather bespoke functionality surrounding the nativeSaveImageandSaveAnimatedWEBPnodes.I've chosen to suggest an extremely lite implementation here, as I suspect we may be expecting some more broadly encompassing work later down the track.
The additional guard included is to make sure that we don't throw a tantrum if we find a match but that match doesn't yet have a
filename_prefixassociated with it.┆Issue is synchronized with this Notion page by Unito