Fix write-single-coil.ts incorrect processing of true value #338 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omation#338 The WriteSingleCoilResponseBody constructor declares that it can handle `boolen` but it can not do that. So I have addled boolean handling into the function.
|
Hi @yangit, thank you for your commitment. This needs to be tested in the unit test. Can you provide a test? |
|
Would be great I you provide a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the #338
The WriteSingleCoilResponseBody constructor declares that it can handle
boolenbut it can not do that. So I have addled boolean handling into the function.Manually tested for both
trueandfalseinput.I have tried to make commit a oneliner like so
this._value = value === ( true || 0xFF00 ? 0xFF00 : 0x0000)But did not find it readable enough and did not like being dependent on parenthesis
I have not added any automated test for this fix because unfortunately I'm unable to properly run
npm installneither on my mac nor on ubuntu, theSerialPortpackage fails to install and I have further issues with mocha (I did try to install that globally along with sinon).Hope that helps!